Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingame settings menu #1561

Closed
AJenbo opened this issue Apr 17, 2021 · 8 comments · Fixed by #3829
Closed

Ingame settings menu #1561

AJenbo opened this issue Apr 17, 2021 · 8 comments · Fixed by #3829
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@AJenbo
Copy link
Member

AJenbo commented Apr 17, 2021

To help with managing the ever-growing list of game options we would like to provide an advanced options menu based on the Help/Shop interface.

Here is a basic mockup of what such a menu could look like:
image

I have not thought of how to indicate that some options will only take effect in new games or by restarting the game, feel free to be creative or have a debate about it.

I'm thinking that this menu will be accessed from menu -> options -> advanced and will replace the "game speed" option.

@AJenbo AJenbo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 17, 2021
@galaxyhaxz
Copy link
Member

Great idea, some games that require restart will usually have text that comes up when changing an option and then when leaving the menu it recreates the window context. This works perfectly fine on desktops, but doubt it would work well on game consoles.

@AJenbo
Copy link
Member Author

AJenbo commented Apr 17, 2021

Recreating the window probably won't work for enabling all quests :)

@galaxyhaxz
Copy link
Member

Options like those should be added to the UI when creating a game IMO. Just like selecting difficulty.

@AJenbo
Copy link
Member Author

AJenbo commented Apr 17, 2021

Unfortunately, the game creates UI isn't good for handling multiple options. Currently you have to mandatorily go over each of them one at a time before you are allowed to start the game. So for the first iteration, I think it's acceptable to have all options listed in this menu. Then later we can create a more flexible Create Game screen that supports multiple options on a single screen (proposals are wellcome).

@galaxyhaxz
Copy link
Member

I've had this implemented in my own UI for almost a year now ;P
Untitled

@Sircrashalot
Copy link

Nice. Will you also add the option for attacking with just one click? Although i loved to spam click back in the good old days... i am just too old for that now :D

@julealgon
Copy link
Contributor

Will you also add the option for attacking with just one click? Although i loved to spam click back in the good old days... i am just too old for that now :D

@Sircrashalot this is not the place to ask about settings themselves. This issue is to discuss how the existing settings are displayed in-game. If you want to discuss actual settings proposals, open another issue or start a discussion.

Having said that, specifically talking about "holding mouse button to attack constantly", it is already in development in some form, so the feature is definitely being considered.

@AJenbo
Copy link
Member Author

AJenbo commented Apr 20, 2021

An even better place to ask questions is the chat https://discord.gg/YQKCAYQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants