Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player can say multiple things at the same time #252

Closed
AJenbo opened this issue Sep 15, 2019 · 1 comment
Closed

Player can say multiple things at the same time #252

AJenbo opened this issue Sep 15, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AJenbo
Copy link
Member

AJenbo commented Sep 15, 2019

Players are able to say multiple things at the same time, the easiest way to trigger this is to not have a spell selected and then right click multiple times.

The correct behavior is to wait until the first sound is done playing before allowing a new one to start. This could be an issue with how GetStatus is implemented, leaving snd_playing to always believe that the sound isn't playing.

@AJenbo AJenbo added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 15, 2019
@AJenbo AJenbo added this to the Diablo 1.09 parity milestone Sep 15, 2019
@AJenbo
Copy link
Member Author

AJenbo commented Sep 24, 2019

Fixed via 2c86411

@AJenbo AJenbo closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant