Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asio build fails on macOS #6074

Closed
bubio opened this issue May 4, 2023 · 5 comments · Fixed by #6130
Closed

asio build fails on macOS #6074

bubio opened this issue May 4, 2023 · 5 comments · Fixed by #6130
Milestone

Comments

@bubio
Copy link
Contributor

bubio commented May 4, 2023

Operating System

Mac

DevilutionX version

Custom build (please specify commit ID)

Describe

Custom build:
defc52f

macOS 13.3.1 (a)(22E772610a)
Xcode 14.3 (14E222b)

Failure to build asio.

devilutionX/build/_deps/asio-src/asio/include/asio/buffer.hpp:29:
devilutionX/build/_deps/asio-src/asio/include/asio/detail/type_traits.hpp:88:12: error: no member named 'result_of' in namespace 'std'
using std::result_of;

Perhaps it is the following :
chriskohlhoff/asio#912

To Reproduce

Build with the following commands :

brew bundle install
cmake -S. -Bbuild -DBUILD_TESTING=OFF -DMACOSX_STANDALONE_APP_BUNDLE=ON -DDISCORD_INTEGRATION=ON
cmake --build build -j $(sysctl -n hw.physicalcpu) --target package

Expected Behavior

No response

Additional context

I was able to build after changing devilutionX/3rdParty/asio/CMakeLists.txt as follows :

add_library(asio INTERFACE)
target_compile_definitions(asio INTERFACE ASIO_HAS_STD_INVOKE_RESULT=ON)  # <- add this
target_include_directories(asio INTERFACE ${asio_SOURCE_DIR}/asio/include)
@Trihedraf
Copy link
Collaborator

I just got an m1 today and I got the same error.

@AJenbo AJenbo added this to the 1.5.0 milestone May 10, 2023
@AJenbo
Copy link
Member

AJenbo commented May 21, 2023

Could you check again, we updated ASIO which should resolve the issue.

@Trihedraf
Copy link
Collaborator

Works for me 👍

@AJenbo
Copy link
Member

AJenbo commented May 21, 2023

Thanks

@bubio
Copy link
Contributor Author

bubio commented May 24, 2023

Works for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants