Inventory items morphing in hellfire mode

[joewis]

Describe
All found items in the inventory are morphing when starting a new game in hellfire mode

To Reproduce
Steps to reproduce the behavior:

1. Start game in (default) hellfire mode, create a new character
2. Go to cathedral and obtain a few items from the church personnel approaching you there
3. start a new game
4. Open inventory and see morphed items
5. Start new game again and see different morphed items

Expected behavior
Items shouldn't morph

Screenshots

multi_0.hsv.gz

Additional context
Built from a freshly cloned version DevilutionX v1.1.0-290098fd buillt pn 32bit Linux

[Trihedraf]

Confirm happens in MinGW x86 and MSVC x86 and x64. Only Hellfire Multiplayer. Hellfire Singleplayer and Diablo Single and Multi are fine.

[AJenbo]

Thanks, the cause of this is that at the moment all multiplayer save games are considered to be Diablo. I still have to decide research if there is a way to detect a Hellfire hero, or if we have to add our own flag for this.
Note this issue also affect new hellfire single player heros loaded in diablo, but nothing is really lost there as all you would have to redo is enter the hero name.

The way hellfire (and DeviutionX) detects the save game version by looking at the header of the game file in the savegame. But this doesn't apply for new heros and multiplayer as they only contain the hero file. I suppose a good start would be to set it to the current game mode by default :)

[galaxyhaxz]

I think it would be good to unify multi and single saves. The way it currently sits, the packed player save is the same size and there isn't a reliable way to ensure a new save is hellfire or diablo. There are reserved fields you may set a flag in :P

[qndel]

being able to use same character to play both in single and multi is indeed an interesting idea

[galaxyhaxz]

They separated them with the intention it would help prevent cheating on battle.net. Only to realize everyone just used trainers that modify the in game memory ;P

[AJenbo]

Fixed in a5ca521

Unfortunately, the save games created with the bugged code will be affected but new items found will work correctly.