Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database.url syntax clarity #10

Closed
LeviSnoot opened this issue Jun 29, 2021 · 0 comments
Closed

database.url syntax clarity #10

LeviSnoot opened this issue Jun 29, 2021 · 0 comments

Comments

@LeviSnoot
Copy link

LeviSnoot commented Jun 29, 2021

This might help inexperienced people like me when setting up zipline.

In the Database Config section of the docs, examples are given for various database urls. To me it was confusing to see user, password and database all being referred to as 'zipline'. I figured it out with some trial and error but could've saved some time at this step.

Original:

// for postgresql
'postgres://zipline:zipline@localhost:5432/zipline'

// for mysql
'mysql://zipline:zipline@localhost:3306/zipline'

// for sqlite
'file:zipline.db'

My suggestion:

// for postgresql
'postgres://user:password@localhost:5432/database'

// for mysql
'mysql://user:password@localhost:3306/database'

// for sqlite
'file:zipline.db'
@diced diced closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants