Use outfits.openneo-assets.net for outfit images #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`outfits.openneo-assets.net` is the more canonical host for outfit images, and we control the traffic differently sometimes. Right now, we're working on moving outfit image pressure off of Vercel, and we're only really able to control the `outfits.openneo-assets.net` with that level of granularity right now. So, switching to this host should help Neobot take a bit more pressure off our bill! 馃挅 and help clean up my logs to help confirm that we've actually switched users over! I haven't tested this change, but it seems simple enough? But it might be smart to have this code build an outfit image URL once before shipping imo, depending on how cautious you're feeling! ty friend~ 馃挏
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outfits.openneo-assets.netis the more canonical host for outfit images, and we control the traffic differently sometimes.Right now, we're working on moving outfit image pressure off of Vercel, and we're only really able to control the
outfits.openneo-assets.netwith that level of granularity right now.So, switching to this host should help Neobot take a bit more pressure off our bill! 馃挅 and help clean up my logs to help confirm that we've actually switched users over!
I haven't tested this change, but it seems simple enough? But it might be smart to have this code build an outfit image URL once before shipping imo, depending on how cautious you're feeling!
ty friend~ 馃挏