v4 examples are broken because the actions argument is missing

[SaphuA]

Working on converting a working v3 implementation to v4, but I'm having some issues.

I renamed actions in the config to actionsCreators and initStore to createStore. Then in my consuming component I also added actions to the import from the store.

My config looks like this:

const config = {
    initialState: {
        files: [],
    },
    actionsCreators: {
        addFile: (state, fileName) => {
            // ...
        }
    }
}

The function in the component triggering the action now looks like this (where it would first do this.props.actions...):

addFile = () => {
    actions.addFile(this.state.text);
}

But when the action is called the param fileName is an object containing all the actions instead of the provided value.

Am I missing something here or is something fishy going on? (Working in typescript / webpack so might also be a compilation issue?)

[SaphuA]

Wait.. is this by design?

react-waterfall/src/index.js

Line 68 in c1ae73c

const result = actionsCreators[v](state, actions, ...args)

That would mean that this example should not be working anymore?

react-waterfall/examples/todos/src/store/actions.js

Line 4 in c1ae73c

addTodo: ({ todos }, todo) => ({

And instead should be:

addTodo: ({ todos }, actions, todo) => ({

@didierfranc If you can give me some confirmation I wouldn't mind updating the examples / docs.

[tonthanhhung]

I'm also interested in why the author changed this, is it something could be documented ? Why we need action in another action ?, is it for chainable action ?

[didierfranc]

I'll check examples and update them with v4 final ;)