Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: clusterClass prop missing on gmap-cluster component + can't disable img #81

Closed
2 of 7 tasks
antoinematyja opened this issue Aug 23, 2020 · 6 comments
Closed
2 of 7 tasks
Labels
bug Something isn't working needs more info The maintainers asked questions that require answers or ask to test some possible solutions waiting for feedback wontfix

Comments

@antoinematyja
Copy link

Describe the bug
Hello :) First of all thanks for this library 馃憤

I'm trying to use the cluster component like this:
https://googlemaps.github.io/v3-utility-library/packages/markerclustererplus/examples/advanced_example.html
The last cluster style : "Circles (css only)".

To reproduce this I need to set a few things like here :
https://github.com/googlemaps/v3-utility-library/blob/master/packages/markerclustererplus/examples/advanced_example.html#L235

The gmap-cluster component has a styles prop, but no clusterClass prop. It would be nice to add it.
https://googlemaps.github.io/v3-utility-library/interfaces/_google_markerclustererplus.markerclustereroptions.html#clusterclass

Even with this property, I didn't manage to achieve the same result as the example.
I set the styles prop to:

      [
        {
          width: 30,
          height: 30,
          className: 'custom-clustericon-1'
        },
        {
          width: 40,
          height: 40,
          className: 'custom-clustericon-2'
        },
        {
          width: 50,
          height: 50,
          className: 'custom-clustericon-3'
        }
      ]

(and add css styles)

But the gmap-cluster component stills render a <img src="undefined"> and won't apply the class. My guess is that a undefined url is provided and takes over the styles.

To Reproduce
Create a map with a gmap-cluster, try to set styles prop to this:

      [
        {
          width: 30,
          height: 30,
          className: 'custom-clustericon-1'
        },
        {
          width: 40,
          height: 40,
          className: 'custom-clustericon-2'
        },
        {
          width: 50,
          height: 50,
          className: 'custom-clustericon-3'
        }
      ]

Expected behavior
Cluster should be rendered with custom-clustericon-* classes

Current behavior
A <img src="undefined"> is rendered

Screenshots
Nope

Desktop (please complete the following information):

  • OS: macOS Catalina
  • Browser: Chrome
  • Version: 84

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Nope

Versions

  • Node: 12.8
  • NPM: 6.14.4
  • Yarn:

Package manager

  • NPM
  • Yarn

Plugin version

  • 1.4.0
  • 1.2.2
  • 1.2.1
  • 1.2.0
  • 1.0.0
@antoinematyja antoinematyja added the bug Something isn't working label Aug 23, 2020
@close-issue-app
Copy link

This issue is closed because it does not meet our issue template. Please read it.

@stale
Copy link

stale bot commented Dec 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 29, 2020
@stale stale bot closed this as completed Jan 5, 2021
@diegoazh diegoazh added the recheck Issue thats need to be rechecked again label Mar 14, 2021
@diegoazh diegoazh reopened this Mar 14, 2021
@stale stale bot removed the wontfix label Mar 14, 2021
@stale
Copy link

stale bot commented May 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 14, 2021
@stale stale bot closed this as completed May 21, 2021
@diegoazh diegoazh reopened this Nov 18, 2021
@stale stale bot removed the wontfix label Nov 18, 2021
@diegoazh
Copy link
Owner

@antoinematyja try the new version 2.0.0 and let me know if you find any issue there. Thanks and apologize for the bot and the delay.

@diegoazh diegoazh added needs more info The maintainers asked questions that require answers or ask to test some possible solutions waiting for feedback and removed recheck Issue thats need to be rechecked again labels Nov 26, 2021
@stale
Copy link

stale bot commented Jan 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 26, 2022
@stale stale bot closed this as completed Feb 3, 2022
@diegoazh
Copy link
Owner

diegoazh commented Feb 9, 2022

@antoinematyja cluster is working properly on the new v2.0.3 please test it. Regards.

Repository owner locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs more info The maintainers asked questions that require answers or ask to test some possible solutions waiting for feedback wontfix
Projects
None yet
Development

No branches or pull requests

2 participants