Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash bug on black rectangle. #2

Closed
wants to merge 15 commits into from
Closed

Conversation

azki
Copy link

@azki azki commented Mar 5, 2014

Hi.
ByakuGallery is very useful for me.
Thank you, Thank you!!

In some cases, the crash bug occurs.
I had to add a test case to bug.
And add a code for fix it.
Please review my code.

azki added 3 commits March 5, 2014 10:27
---
FATAL EXCEPTION: Thread-4115
java.lang.NullPointerException: key == null || value == null
at android.support.v4.util.LruCache.put(LruCache.java:117)
at com.diegocarloslima.byakugallery.lib.TileBitmapDrawable$DecoderWorker.run(TileBitmapDrawable.java:453)
@azki
Copy link
Author

azki commented Mar 5, 2014

Use Paint.FILTER_BITMAP_FLAG for improve image quality. (Anti-Alias on PNG Images)

before : http://cfile240.uf.daum.net/original/2128633353168C5B2876A6
after : http://cfile204.uf.daum.net/original/2130263353168C5A23B466

@diegocarloslima
Copy link
Owner

Hi azki, thank you for the contribution. I'll take a look on that this weekend and update the lib asap.

@diegocarloslima
Copy link
Owner

There is some sort of problem with this specific image that prevents the decoder from decoding some regions. Once is a decoder problem, there isn't much I can do about it. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants