Don't throw exception on failure #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of throwing the exception when BitmapRegionDecoder.newInstance fails, trigger an onError(Exception) callback. - Update compile SDK and grade version - Add a way to clear the bitmap cache as it can fill up rather quickly
|
Hey @Kennyc1012! Thanks for your contribution. I'll take a look at your code this week ok? |
|
Take your time, I built an aar for myself to use in one of my projects that is currently live. Thanks for the great library. |
diegocarloslima
added a commit
that referenced
this pull request
Jan 25, 2015
Don't throw exception on failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitmapRegionDecoder.newInstance fails, trigger an onError(Exception)
callback.
Most of the conflicts are due to the formatter be run.