Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore ISBN for book chapters and conference papers #102

Open
diegodlh opened this issue May 31, 2021 · 2 comments
Open

Ignore ISBN for book chapters and conference papers #102

diegodlh opened this issue May 31, 2021 · 2 comments
Labels
bug Something isn't working data model PIDs issues involving persistent identifiers such as dois, isbns and qids

Comments

@diegodlh
Copy link
Owner

ISBN should be ignored for book chapters, as they refer to the book they belong to, not to the book chapter itself.

As a result, the Wikidata reconciliation service may return the QID for the book it belongs to, instead of the QID for the corresponding book chapter.

This could be addressed in the ItemWrapper class directly.
@diegodlh diegodlh mentioned this issue May 31, 2021
Closed
@diegodlh
Copy link
Owner Author

Same thing applies for Conference Papers. Any other?

@diegodlh diegodlh mentioned this issue Feb 7, 2022
Closed
@diegodlh
Copy link
Owner Author

diegodlh commented Feb 7, 2022

In addition, this causes that multiple citations to different conference papers with different DOIs but with the same container ISBN can't be added to the same citing item, as described by @Dominic-DallOsto in #159. As mentioned there, this is related to #37.

@diegodlh diegodlh added bug Something isn't working PIDs issues involving persistent identifiers such as dois, isbns and qids labels Feb 7, 2022
@diegodlh diegodlh changed the title Ignore ISBN for book chapters Ignore ISBN for book chapters and conference papers Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working data model PIDs issues involving persistent identifiers such as dois, isbns and qids
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diegodlh