Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import type * from rxjs error #9

Closed
Crocsx opened this issue Apr 26, 2020 · 4 comments
Closed

import type * from rxjs error #9

Crocsx opened this issue Apr 26, 2020 · 4 comments
Assignees

Comments

@Crocsx
Copy link

Crocsx commented Apr 26, 2020

Hello,

I recently discovered this package which looks really cool, but I get a problem when using it in my angular app:

I did npm install joymap but at compilation time I get the following

ERROR in ../node_modules/joymap/bin/src/streamModule/stream.d.ts:1:13 - error TS1005: '=' expected.

1 import type * as rxjs from 'rxjs';
              ~
../node_modules/joymap/bin/src/streamModule/stream.d.ts:1:18 - error TS1005: ';' expected.

1 import type * as rxjs from 'rxjs';
                   ~~~~
../node_modules/joymap/bin/src/streamModule/stream.d.ts:1:23 - error TS1005: ';' expected.

1 import type * as rxjs from 'rxjs';
                        ~~~~
../node_modules/joymap/bin/src/streamModule/stream.d.ts:1:28 - error TS1005: ';' expected.

1 import type * as rxjs from 'rxjs';
                             ~~~~~~
../node_modules/joymap/bin/src/streamModule/stream.d.ts:2:13 - error TS1005: '=' expected.

2 import type * as operators from 'rxjs/operators';
              ~
../node_modules/joymap/bin/src/streamModule/stream.d.ts:2:18 - error TS1005: ';' expected.

2 import type * as operators from 'rxjs/operators';
                   ~~~~~~~~~
../node_modules/joymap/bin/src/streamModule/stream.d.ts:2:28 - error TS1005: ';' expected.

2 import type * as operators from 'rxjs/operators';
                             ~~~~
../node_modules/joymap/bin/src/streamModule/stream.d.ts:2:33 - error TS1005: ';' expected.

2 import type * as operators from 'rxjs/operators';
                                  ~~~~~~~~~~~~~~~~
 

I remove the import type to import and it works ok.

@diegodoumecq
Copy link
Owner

Thanks for the compliment! I've just published version 2.2.2 which includes a fix for this issue.

@Crocsx
Copy link
Author

Crocsx commented May 4, 2020

@diegodoumecq thank you, It works great after fixing the few changes you made.

Just a last thing, I think your forgot a log in the app cause I get

https://prnt.sc/saf5ub

@diegodoumecq
Copy link
Owner

Yes indeed! Sorry about that, seems like I've been getting careless. Now fixed in version 2.2.4

Oh, also, I've changed how the library is exported so do let me know if I broke something for you (so far I think everything is working correctly)

@Crocsx
Copy link
Author

Crocsx commented May 4, 2020

Thank you !

I just use it for basic things at the moment (axis event, and button event). After some minor changes to how event works, my app works great like before.

I keep you updated if I found any problem.

Thank you for your work

@diegodoumecq diegodoumecq self-assigned this May 4, 2020
@Crocsx Crocsx closed this as completed May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants