Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal][next-version] Merge branches into one #112

Closed
kybarg opened this issue Feb 18, 2017 · 2 comments
Closed

[proposal][next-version] Merge branches into one #112

kybarg opened this issue Feb 18, 2017 · 2 comments

Comments

@kybarg
Copy link
Collaborator

kybarg commented Feb 18, 2017

There are many branches in this project each dedicated to some usage case. I suggest to merge all branches into one, but let user to specify install options depending on which one will get installation of redux, fullstack, universal-redux etc.
Other variant is to have basic pack and extend with yeoman generator.

@diegohaz
Copy link
Owner

Having those branches can make our work a little harder, but the gain is enormous.

  • It helps us to better handle and track bugs;

  • If something breaks on universal-redux, the other branches will be fine;

  • If we need to upgrade some library, like react-router v4 for example, we don't need to worry about whether it will work with redux and SSR or not. We can just upgrade it on master and leave the others with v3 until it has proper support;

  • Even if we focus on the generator-arc (and that's the plan), let people to git clone the boilerplate easily is desirable since one can take advantage of git history (to keep local in sync);

  • If one already has a project and want to know how to implement redux, for example, comparing branches can help them:

    image

@diegohaz
Copy link
Owner

But I'll probably look for a maintainer for fullstack soon since I'm not using that branch on any project and therefore can't guarantee further improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants