New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[universal-redux] Global styles applied several times now #11
Comments
Maybe we need to move |
I just realised that it adds up with every page refresh edit: what do you mean with outside of the component? |
It makes sense. |
I mean something like this: injectGlobal`
body {
margin: 0;
}
`
class App extends Component {
... |
That works! |
Nice! Would you mind to send a PR with this on master (I merge with other branches later)? The files are |
After your latest bug fix (moving globalInjects to componentWillMount) global styles are applied several times on the server.
On your demo page (https://arc.diegohaz.com/) the global styles are applied 3 times. In my app which has a little more global styles, they are applied up to 12 times. It seems like this grows over time.
I will investigate a little and post my findings.
The text was updated successfully, but these errors were encountered: