Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run build fails on windows10 using node 4.4.2 #65

Closed
EdwinKato opened this issue Jan 13, 2017 · 10 comments
Closed

npm run build fails on windows10 using node 4.4.2 #65

EdwinKato opened this issue Jan 13, 2017 · 10 comments

Comments

@EdwinKato
Copy link

arc error

@diegohaz
Copy link
Owner

Probably related to #62

Does it work if you replace ' by \"?

Also, I recommend you to update node to version >= 6 otherwise you will not be able to run npm test.

@EdwinKato
Copy link
Author

I have upgraded both npm and node to latest versions and also tried the replacement you mentioned above but it still doesnt work.

@diegohaz
Copy link
Owner

Try to remove the npm run build:clean from the prebuild script.

I'm not able to dig into this (I'm not on Windows), so I'll be really grateful if you (or anyone using Windows) could figure out what's happening with those scripts.

@EdwinKato
Copy link
Author

Alright, Let me try to tweak it around and see if i can get it to work. I will give you feedback after.

@EdwinKato
Copy link
Author

Could you please tell me fully what you are trying to achieve with the command?. I can only understand half of it. Not sure what the Procfile is doing there. I can get my local copy to work by deleting everthing in the dist folder but i fear this is not what you intended.

@diegohaz
Copy link
Owner

diegohaz commented Jan 13, 2017

npm run clean removes everything on dist except .git (for the cases when you have a repository/branch for the static files. I'm doing this to provide https://arc.js.org - the branch gh-pages is the dist folder) and Procfile.

Procfile is part of Heroku deployment process and is not necessary, but one can use.

If you don't do that, you can just remove the entire folder.

@kybarg
Copy link
Collaborator

kybarg commented Feb 18, 2017

@EdwinKato replace del with del-cli in package.json in build:clean command.

@diegohaz
Copy link
Owner

Amazing, @kybarg (now I got that change on #108 😆)

Would you mind to send a PR on master?

@kybarg
Copy link
Collaborator

kybarg commented Feb 18, 2017

@diegohaz no problem

diegohaz added a commit that referenced this issue Feb 18, 2017
@diegohaz diegohaz added the bug label Feb 18, 2017
@diegohaz
Copy link
Owner

Fixed in #115

Thank you @kybarg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants