Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated createMemoDeps parameter #100

Merged
merged 1 commit into from Feb 15, 2020

Conversation

diegohaz
Copy link
Owner

This PR removes the deprecated createMemoDeps function that was passed as the second argument of the constate function.

So, this is a breaking change and should be released as v2.0.0.

Before:

const useCounterContext = createUseContext(useCounter, value => [value.count]);

After:

const useCounterContext = createUseContext(() => {
  const value = useCounter();
  return useMemo(() => value, [value.count]);
});

@diegohaz diegohaz merged commit 553405d into master Feb 15, 2020
@diegohaz diegohaz deleted the feat/remove-create-memo-deps branch February 15, 2020 21:26
@codecov-io
Copy link

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #100   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          50     43    -7     
  Branches       10      5    -5     
=====================================
- Hits           50     43    -7
Impacted Files Coverage Δ
src/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db9e27...d698043. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants