Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles composition with styled-components@4 #6

Closed
brabeji opened this issue Oct 9, 2018 · 1 comment
Closed

styles composition with styled-components@4 #6

brabeji opened this issue Oct 9, 2018 · 1 comment

Comments

@brabeji
Copy link

brabeji commented Oct 9, 2018

Hello @diegohaz!

I've realized that contrary to my first impression, reuse is not aware of styled-components@4 component extension feature. That makes predictable overriding of styles impossible, as the order of generated classes depends on component declaration/import order.

This might be out of scope for reuse if CSS properties of combined components are considered disjunct by convention, which might be a good idea.

I still see a lot of potential in this so I took a quick hack at that here https://github.com/brabeji/styled-compose

What do you think?

@diegohaz
Copy link
Owner

Awesome solution, @brabeji.

I'll be looking forward to seeing where it goes. Keep the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants