Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nice to have: grunt-bower-task #26

Closed
jeromerg opened this issue Mar 25, 2014 · 3 comments
Closed

nice to have: grunt-bower-task #26

jeromerg opened this issue Mar 25, 2014 · 3 comments

Comments

@jeromerg
Copy link

Hi,

generator-ionic is the best generator/seed I found, for the ionic framework!

it would be nice if one didn't even have to call bower install. The plugin grunt-bower-task could be added into GruntFile, in order to update bower dependencies.
It would ensure also ensure, that if a developer adds a new bower-dependency, then other developers (and build-server) get it automatically.

Or is there any reason for not introducing this feature?

@oori
Copy link
Contributor

oori commented Mar 25, 2014

bower-install is already in there.. see Gruntfile.js ---- @diegonetto is right..
https://github.com/diegonetto/generator-ionic/blob/master/templates/common/Gruntfile.js#L138

@diegonetto
Copy link
Owner

The grunt bower-install task doesn't actually run bower install. It injects dependencies managed by bower into your index.html files so you don't have to. Here's the plugin - https://github.com/stephenplusplus/grunt-bower-install

There are two schools of thought when it comes to managing the bower_components and node_modules directories. There are arguments that support both excluding them from version control and having the final build system pull them in, or packaging them with your repository.

This issue got more coverage when the NPM registry went down for a bit last year, causing many build systems to hang. Here's a great post by @addyosmani on checking in front end dependencies.

For now, I think we should leave it up to the user's discretion. Tapping into githooks and having it run npm install && bower install on the post-merge hook would probably be the way I'd handle it.

@jeromerg
Copy link
Author

Thank you for the detailed response! That's exactly the dilemma I was confronted to. But I understand your decision.

Githooks are outside the build-process and everyone has to configure it on his own... I am currently aiming at simplifying the build process, so that the other programmers can easily build and run an app and its server. So it is not an alternative for my current issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants