Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong path to icon font in concatenated vendor.css #8

Closed
stizzlestizzle opened this issue Mar 11, 2014 · 2 comments
Closed

Wrong path to icon font in concatenated vendor.css #8

stizzlestizzle opened this issue Mar 11, 2014 · 2 comments
Labels

Comments

@stizzlestizzle
Copy link

Nice Generator.

Using v 0.0.6 here.

Running the app in the iOS emulator results in all icons not being shown. This is because the path to all instances of the icon font inside vendor.css is wrong.

It is
"/bower_components/ionic/release/fonts/ionicons.eot"
"/bower_components/ionic/release/fonts/ionicons.ttf"
etc.

But it should be
"../bower_components/ionic/release/fonts/ionicons.eot"
"../bower_components/ionic/release/fonts/ionicons.ttf"

@diegonetto
Copy link
Owner

Thanks for pointing this out - I noticed this as well. Should have it fixed by this evening.

@diegonetto diegonetto added the bug label Mar 12, 2014
@diegonetto
Copy link
Owner

So I re-evaluated the packaging of assets for production. Since we are concatenating, obfuscating, and minifying all of our assets, there is no real reason to copy the bower_components into the www directory for production.

Since its fairly common including an app/fonts/ directory, I've updated the Gruntfile with a copy:fonts task that copies the Ionic fonts from bower_components into that location. This way, apps can bundle any custom fonts as well and they will all get copied over to www/fonts as part of the production pipeline.

The last bit was updating cssmin to not rebase relative urls, so that the reference inside of ionic.css would work properly.

This has been fixed in version 0.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants