Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use the right overlay based on engagement mode. #14

Merged

Conversation

noordawod
Copy link
Contributor

Works on my end, doctor -v:

[✓] Flutter (Channel master, 1.22.0-10.0.pre.380, on Linux, locale en_US.utf8)
    • Flutter version 1.22.0-10.0.pre.380 at /home/noor/Google/Flutter
    • Framework revision ec40df9576 (2 days ago), 2020-09-25 21:27:22 -0700
    • Engine revision 3a73d073c8
    • Dart version 2.11.0 (build 2.11.0-161.0.dev)

Copy link
Owner

@diegoveloper diegoveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm there are more issues than the color. Please try using stable version

@noordawod
Copy link
Contributor Author

Alright. May I ask what version of Flutter are you using?

@noordawod
Copy link
Contributor Author

I know what's the problem now. I'll issue a fix tomorrow, it's very late here.
Very sorry for the mishap, but will fix it asap tomorrow.

@noordawod
Copy link
Contributor Author

GestureDetector's drag start/end is reset when a dialog is presented. So the solution is to use an Overlay when engagement mode is drag, and use a Dialog when it is tap.

@diegoveloper
Copy link
Owner

I tried on iOS simulator , Flutter (Channel stable, 1.20.3)

@noordawod
Copy link
Contributor Author

Good morning! Patch has been submitted, and tested to work nicely here.
Let me know if you face any more problems :)

@noordawod noordawod changed the title Use a color with a 0 alpha channel that isn't equal to Colors.transparent. Properly use the right overlay based on engagement mode. Sep 28, 2020
@diegoveloper diegoveloper merged commit cd968a6 into diegoveloper:master Sep 28, 2020
@diegoveloper
Copy link
Owner

Thanks, it's working fine now :D

@noordawod
Copy link
Contributor Author

Brilliant! Thank you for the initial version, I love this plugin :) If I have more things, I'll submit more pr's.

@noordawod noordawod deleted the bugfix/barrier-non-transparent branch September 28, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants