[State Sync] Add MempoolNotifier interface and implementation. #9006 - (124) #10671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaneshacn
approved these changes
Dec 28, 2022
|
/canary |
|
💔 Test Failed - ci-test |
|
/canary |
|
💔 Test Failed - ci-test |
|
/canary |
|
☀️ Canary successful |
|
/land |
|
💔 Test Failed - ci-test |
|
Closing this PR due to technical issue, raised new one #10683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Today, state sync is responsible for notifying mempool whenever new transactions are committed. However, the interface between the two components is very messy, e.g., the code leaks implementation details between the components and forces a very tight coupling. This makes it difficult to update (or swap out) component implementations.
To address this, the PR introduces an explicit interface and set of components between state sync and mempool:
MempoolNotificationSenderis the interface allowing state sync to send notifications to mempool (MempoolNotifieris the component that implements this interface).MempoolNotificationListeneris the component that mempool uses to listen for notifications and respond accordingly.This structure avoids leaking implementation details (e.g., the fact that we use a one-shot callback to respond to notifications). In addition, the PR adds explicit (previously missing) tests for the implementation.
Note: at a fundamental level, this new interface implementation still uses channels, but wraps the interface-specific details of the communication (e.g., message formats, channel timeouts, etc.) to offer better implementation encapsulation.
Test Plan
CI/CD testcases were covered.