Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up`left_join` incorrectly compiling if additional joins are done afterwards #1459
Comments
This comment has been minimized.
|
I actually don't know if we can fix this until disjointness based on associated types lands. We need to change this impl:
to be these two impls:
I need to think about this more to come up with a way to fix this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedJan 7, 2018
•
edited
Reported via gitter. This query compiles successfully:
It should fail to compile unless
.nullablehas been called onrevision::hash. Reversing the order of the join calls causes this code to fail to compile as it should