Bug 508601 - Copying from GTK+ applications causes crash

In GtkClipboardOwner pasteboard:provideDataForType do not call _gtk_quartz_set_selection_data_for_pasteboard() is selection_data.length is smaller than 0. The function relies on having a positive length, since it stores the length in a uint ...
dieterv · Jul 25, 2011 · 8d69f3d · 8d69f3d
1 parent b0dd7e1
commit 8d69f3d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/gtk/gtkclipboard-quartz.c b/gtk/gtkclipboard-quartz.c
@@ -110,9 +110,10 @@ struct _GtkClipboardClass
       clipboard->get_func (clipboard, &selection_data,
                            info,
                            clipboard->user_data);
-
+
-      _gtk_quartz_set_selection_data_for_pasteboard (clipboard->pasteboard,
+      if (selection_data.length >= 0)
-                                                     &selection_data);
+        _gtk_quartz_set_selection_data_for_pasteboard (clipboard->pasteboard,
+                                                       &selection_data);
 
       g_free (selection_data.data);
     }