Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - check whether the IP address is being throttled #2

Closed
tautology0 opened this issue Nov 22, 2021 · 3 comments
Closed

Enhancement - check whether the IP address is being throttled #2

tautology0 opened this issue Nov 22, 2021 · 3 comments
Assignees
@dievus
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tautology0
Copy link

The results may get throttled - in that case you'll be returned with false positives (i.e. it always returns "IfExistsResults":0). You can check throttle by looking whether "ThrottleStatus":1.

If would be nice to return a warning in this case.
@dievus
Copy link
Owner

dievus commented Nov 22, 2021

Great idea. I'll get it added.

@dievus
Copy link
Owner

dievus commented Nov 22, 2021

This is integrated. If you would like to do a pull and test it to let me know if you're getting the same success from the change as I am I would greatly appreciate it.

@dievus dievus self-assigned this Nov 22, 2021
@dievus dievus added the enhancement New feature or request label Nov 22, 2021
@dievus dievus closed this as completed Nov 22, 2021
@tautology0
Copy link
Author

Looks good to me! Thanks for the change!

@dievus dievus added the good first issue Good for newcomers label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dievus dievus

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tautology0 @dievus