fix: move custom error types to a better place and refactor

diez · Nov 14, 2019 · 6daed20 · 6daed20
1 parent bdd4718
commit 6daed20
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 7 deletions.
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -38,6 +38,7 @@
     "commander": "^2.19.0",
     "enquirer": "^2.3.0",
     "fs-extra": "^7.0.1",
+    "typed-errors": "^1.1.0",
     "server-destroy": "^1.0.1"
   },
   "bin": {

diff --git a/packages/cli/src/errors.ts b/packages/cli/src/errors.ts
@@ -0,0 +1,3 @@
+import {makeTypedError} from 'typed-errors';
+``
+export const UnauthorizedRequestException = makeTypedError('UnauthorizedRequestException');
diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts
@@ -2,3 +2,4 @@ export * from './api';
 export * from './utils';
 export * from './reporting';
 export * from './network';
+export * from './errors';
diff --git a/packages/cli/tsconfig.json b/packages/cli/tsconfig.json
@@ -2,7 +2,8 @@
   "extends": "../tsconfig.packages.json",
   "compilerOptions": {
     "rootDir": "src",
-    "outDir": "lib"
+    "outDir": "lib",
+    "baseUrl": "."
   },
   "include": [
     "src/**/*.ts"

diff --git a/packages/designfile/package.json b/packages/designfile/package.json
@@ -27,7 +27,6 @@
     "pngjs": "^3.3.3",
     "request": "^2.88.0",
     "server-destroy": "^1.0.1",
-    "typed-errors": "^1.1.0",
     "uuid": "^3.3.2"
   },
   "devDependencies": {

diff --git a/packages/designfile/src/commands/extract.action.ts b/packages/designfile/src/commands/extract.action.ts
@@ -1,11 +1,10 @@
-import {info, success, warning} from '@diez/cli';
+import {info, success, warning, UnauthorizedRequestException} from '@diez/cli';
 import {Registry} from '@diez/storage';
 import {prompt} from 'enquirer';
 import {ExporterFactory} from '../exporters';
 import {FigmaExporter, getFigmaAccessToken} from '../exporters/figma';
 import {IllustratorExporter} from '../exporters/illustrator';
 import {SketchExporter} from '../exporters/sketch';
-import {UnauthorizedRequestException} from '../helpers/request';
 
 const findFactory = async (source: string): Promise<ExporterFactory> => {
   for (const factory of [FigmaExporter, IllustratorExporter, SketchExporter]) {

diff --git a/packages/designfile/src/helpers/request.ts b/packages/designfile/src/helpers/request.ts
@@ -1,8 +1,6 @@
 import {createWriteStream, unlink} from 'fs-extra';
 import request, {Headers} from 'request';
-import {makeTypedError} from 'typed-errors';
-
-export const UnauthorizedRequestException = makeTypedError('UnauthorizedRequestException');
+import {UnauthorizedRequestException} from '@diez/cli';
 
 export const performGetRequestWithBearerToken = <T>(uri: string, token: string): Promise<T> => {
   return performGetRequest<T>(uri, true, {Authorization: `Bearer ${token}`});

diff --git a/packages/designfile/src/typed-errors.d.ts → packages/types/typed-errors.d.ts b/packages/designfile/src/typed-errors.d.ts → packages/types/typed-errors.d.ts