fix(targets): prevent exceptions on JS SDK (#285)

- Prevent errors when assigning readonly 'name' property. - Prevent exceptions when used with webpack DefinePlugin
diez · Nov 14, 2019 · eb2b4c1 · eb2b4c1
1 parent 5796249
commit eb2b4c1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/packages/targets/sources/web/js.component.handlebars b/packages/targets/sources/web/js.component.handlebars
@@ -24,7 +24,7 @@ class {{{componentName}}} {
 }
 
 {{#if public}}
-{{{componentName}}}.name = '{{{componentName}}}';
+Object.defineProperty({{{componentName}}}, 'name', {value: '{{{componentName}}}'});
 {{/if}}
 
 module.exports.{{{componentName}}} = {{{componentName}}};
diff --git a/packages/targets/sources/web/sdk/index.js b/packages/targets/sources/web/sdk/index.js
@@ -1,7 +1,9 @@
 if (typeof process === 'undefined' || !process) {
   process = {env: {}};
 } else if (!process.env) {
-  process.env = {};
+  Object.defineProperty(process, 'env', {
+    value: {},
+  });
 }
 
 const Environment = {

diff --git a/packages/targets/test/goldens/Bindings/diez-target-test-stub-web/index.js b/packages/targets/test/goldens/Bindings/diez-target-test-stub-web/index.js
@@ -1,7 +1,9 @@
 if (typeof process === 'undefined' || !process) {
   process = {env: {}};
 } else if (!process.env) {
-  process.env = {};
+  Object.defineProperty(process, 'env', {
+    value: {},
+  });
 }
 
 const Environment = {
@@ -486,7 +488,7 @@ class Bindings {
   }
 }
 
-Bindings.name = 'Bindings';
+Object.defineProperty(Bindings, 'name', {value: 'Bindings'});
 
 module.exports.Bindings = Bindings;
 
diff --git a/packages/targets/test/goldens/Primitives/diez-target-test-stub-web/index.js b/packages/targets/test/goldens/Primitives/diez-target-test-stub-web/index.js
@@ -1,7 +1,9 @@
 if (typeof process === 'undefined' || !process) {
   process = {env: {}};
 } else if (!process.env) {
-  process.env = {};
+  Object.defineProperty(process, 'env', {
+    value: {},
+  });
 }
 
 const Environment = {
@@ -57,7 +59,7 @@ class Primitives {
   }
 }
 
-Primitives.name = 'Primitives';
+Object.defineProperty(Primitives, 'name', {value: 'Primitives'});
 
 module.exports.Primitives = Primitives;