Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JSON output to the web compiler target #126

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented May 11, 2020

No description provided.

@roperzh roperzh requested a review from zackbrown May 11, 2020 21:12
This was linked to issues May 11, 2020
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #126 into master will decrease coverage by 0.00%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   92.44%   92.44%   -0.01%     
==========================================
  Files         135      135              
  Lines        2980     2992      +12     
  Branches       97       98       +1     
==========================================
+ Hits         2755     2766      +11     
  Misses        199      199              
- Partials       26       27       +1     

Copy link
Member

@zackbrown zackbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice elegant solution here. LGTM.

@roperzh roperzh merged commit e4b134d into master May 19, 2020
@roperzh roperzh deleted the rob/web-json-target branch May 19, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: JSON target [Questions] - Json output? React Native?
2 participants