Fixed issues with hotkeys

[PJEstrada]

Seemed that the real problem was not so much with hot keys but with the selected prop of the instances. When we changed frames the watcher would always reset to false the instance select and that would cause some of the hotkeys for related to selection to stop working (like copy and paste).

This was cause due to not updating the this.previous_current_frame value in the watcher. Now the select is working properly and the hotkeys are following

I also tested the w,a,s,d the space bar, the escape keys, numkeys 1-9 and they all seem to be working fine.

Please let me know if you are aware of any other hotkeys malfunctioning so I can dive deeper into them here.

[anthony-sarkis]

Hey,
I tested with the directory select in media bar and was able to reproduce issue of hotkeys. Inspecting state it showed that the flag we check $store.state.user.is_typing_or_menu_open was remaining in true even when deselecting. Watching the mutations I see that it's only firing one event.

I committed d715b85

1. This will cover the blur event (no change) case.
2. I moved the "did select something" case into the change event so it's more clear the relationship of that (vs having it seperate in the update:return value -> which made it look as though it was the mirror of the focus when it's not.

[anthony-sarkis]

I found a few more
2dfb268
Covers

1. Share menu dialog is clicked outside (not close button)
2. Moves the issue dialog creation closer to the actual interface, for menus that don't fill full screen I think this is probably better

userscript select was missing blur
b6c151a

Please double check ok with
f354470
As far as I can see there isn't anything in instance history that needs to disable this,
if there is, then prefer to put it closer to source like in other commits
3e559f7

[anthony-sarkis]

@PJEstrada I think this is ready for a fresh look when ready

[PJEstrada]

Hey Anthony thanks for catching the onBlur issue :) I checked the code and its looking good. I added 2ce3b59 which just adds the delete hotkey in the global context so it still works if the mouse is not inside the canvas.

I will wait for tests to pass and we can merge this to master

[github-actions]

Unit Test Results

  1 files  ±0    1 suites  ±0   52s ⏱️ ±0s
84 tests ±0  84 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e71aad2. ± Comparison against base commit e71aad2.