Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metabase to packaging script #37

Closed
pdobacz opened this issue Oct 11, 2022 · 6 comments · Fixed by #40
Closed

Add Metabase to packaging script #37

pdobacz opened this issue Oct 11, 2022 · 6 comments · Fixed by #40
Assignees

Comments

@pdobacz
Copy link
Collaborator

pdobacz commented Oct 11, 2022

Split out of #5 , which only handles PostgreSQL

@cristianberneanu
Copy link
Contributor

We also need to decide here if we include the JRE with app or require a separate installation.

@cristianberneanu cristianberneanu self-assigned this Oct 18, 2022
@pdobacz
Copy link
Collaborator Author

pdobacz commented Oct 18, 2022

bah, I didn't notice you took this one in the morning and I quickly handled it just now. My implementation is pretty dumb and I've spent close to no time on it, but in case you've not tackled it just yet, you can hold off.

@cristianberneanu
Copy link
Contributor

No problem, I haven't started on it yet, so I'll let you handle it.

@pdobacz
Copy link
Collaborator Author

pdobacz commented Oct 19, 2022

We also need to decide here if we include the JRE with app or require a separate installation.

re this, I'm now looking into. After first glance it seems like bundling JRE is preferred. I actually quite easily managed to install the wrong JRE version, when I wasn't paying enough attention. Even when I followed the recommended links from Metabase page, the correct version was some clicks away.

I see that that JRE is distributed under GNU GPL, this might be an issue for us, no? https://adoptium.net/docs/faq

@pdobacz
Copy link
Collaborator Author

pdobacz commented Oct 19, 2022

OK, I'll cut a follow-up ticket for the JRE part and start working on it

@pdobacz
Copy link
Collaborator Author

pdobacz commented Oct 19, 2022

(lets take the licensing topic to the internal-strategy thread I just started)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants