Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent anonymizations have unexpected effects #5

Closed
sebastian opened this issue Jun 4, 2021 · 1 comment
Closed

Concurrent anonymizations have unexpected effects #5

sebastian opened this issue Jun 4, 2021 · 1 comment

Comments

@sebastian
Copy link
Contributor

sebastian commented Jun 4, 2021

Pre-requisites:

  • have a dataset of decent size, so anonymization takes a while
  • the dataset should have multiple columns

To reproduce:

  • Select one column
  • Immediately select a second

The app will issue two anonymization requests that are run one after the other.
As soon as the first one returns a result, the frontend will consider the result as finished, and will stop showing the "processing animation". This makes it appear to the analyst as if the second column that was added for anonymization was dropped/ignored. A while later, once the second anonymization ends, the result will be updated and everything will be as expected.

It would be ideal if we could terminate other ongoing and queued anonymization requests when making a new one. That way the time to useful results is kept smaller. This would also solve this bug as only the desired anonymization request would ever be returned.

Alternatively we could send a request ID with the anonymization requests, and only mark the anonymiaztion requests as complete if the result for the desired request has been returned. This might be generally useful as we otherwise end up with the risk of a race conditions...

@cristianberneanu
Copy link
Contributor

No longer applicable to the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants