Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsMavenExtension should use buildDir variable #9

Closed
thomasmhofmann opened this issue Sep 16, 2016 · 4 comments
Closed

AsMavenExtension should use buildDir variable #9

thomasmhofmann opened this issue Sep 16, 2016 · 4 comments

Comments

@thomasmhofmann
Copy link

The p2asmaven directory is created in a directory being determined like this:

Object destination = "build/p2asmaven";

In my multip-project build I am setting the buildDir like this:

    /*
     * The buildDir should be in the build project instead of in each separate project.
     */
    buildDir = new File(rootProject.projectDir, "build/" + project.name)

The p2asmaven directory ends up in the subproject's directory.

The class AsMavenExtension could also use the buildDir variable from the project to determine the target location.

@nedtwigg
Copy link
Member

I agree this change should be made, but in the meantime you can override it as such:

p2asmaven {
    destination 'whereveryouwant'
}

Out of curiosity, what did you rename your build directory to and why?

@thomasmhofmann
Copy link
Author

I just wanted to have all build directories of all subprojects in the root project. This way it easier for me to pick the build artefacts and only one directory is changed during the build.

@nedtwigg
Copy link
Member

Gotcha. That seems like a pretty good reason.

@nedtwigg
Copy link
Member

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants