Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1132 - Add magic value to disable ratchetFrom #1134

Merged
merged 3 commits into from
Feb 19, 2022

Conversation

jandhollander
Copy link

@jandhollander jandhollander commented Feb 17, 2022

When overriding the maven plugin configuration from a parent pom in a child pom, there is no way to disable ratchetFrom if it's set to a particular value in the parent.

This PR introduces a magic value 'NONE' that allows to do this.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  1. Update docs with info about the magic NONE constant https://github.com/diffplug/spotless/tree/main/plugin-maven#how-can-i-enforce-formatting-gradually-aka-ratchet
  2. Update plugin-maven/CHANGES.md with
## Unreleased
### Added
- blah blah blah
  1. Run spotlessApply so that the tests pass.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thanks!

@nedtwigg nedtwigg merged commit 139e771 into diffplug:main Feb 19, 2022
@nedtwigg
Copy link
Member

Published in plugin-maven 2.21.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants