Use steps name as task input instead of steps to generate a consistent cache key #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Gradle build cache key
clayburn
reviewed
Jun 12, 2024
| @@ -28,7 +28,7 @@ | |||
| * to not introduce any windows-style newlines as well. | |||
| */ | |||
| public interface FormatterStep extends Serializable, AutoCloseable { | |||
| /** The name of the step, for debugging purposes. */ | |||
| /** The name of the step, for debugging purposes and to uniquely identify a step when computing the Gradle Build Cache key. */ | |||
There was a problem hiding this comment.
What happens if the implementation of the FormatterStep changes? I worry that the name alone is not enough, and that this could introduce negative cache hits.
There was a problem hiding this comment.
That's a very good point, I did not consider implementation changes
There was a problem hiding this comment.
Not sure if relying on (meaningful) hashcode could work
There was a problem hiding this comment.
Double thinking it, an implementation change should be shipped in a new version of the plugin, which would be reflected in the task classpath.
|
Thanks for the initiative, I think this approach is barking up the wrong tree. See my comment in #2168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2168