New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured report of compliance failures #811
Comments
I'm aware of another Gradle plugin, specifically ben-manes/gradle-versions-plugin, which I think allows a custom output format e.g. JSON, so that part of your feature request sounds sensible to me. I'm not entirely sure I understand your suggestion for the plugins' proposed third mode. Are you suggesting that even if the check reports that some code is not formatted, then it doesn't "fail" in the associated build tool? If so, that sounds rather unusual to me. I'm tempted to just expose the option to change the output format of the existing check mode. Just my 2 cents as an ex-contributor. I don't know for sure how this would even look like in Spotless yet. :) |
(Happy to be corrected on any of this but...) in a multi-module maven project running If it helps though, I'm happy to leave all that for a future issue and focus this one on the structured report. |
I'm going to closet this as a dupe of #655. A PR for adding a structured report is indeed welcome, but it would be best to leverage the existing reviewdog diagnostic format. |
My team have requested better integration into our CI than simply failing a maven build, at a minimum they'd like to see a PR comment summarising the state of compliance failures. To my mind this would be best accomplished by:
spotless-report.json
on their status without failing the build.Is there a better / simpler option I should be looking into? Would a structured report like this be welcome for Spotless?
The text was updated successfully, but these errors were encountered: