-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --is-test
to all test commands
#61
Comments
UC 1 Tester of LPP test the app runs successfully
|
sorry, this is all very confusing. We don't need a UC for the tests. We are looking for pseudocode of the actual test functionality. Sorry it is so confusing. Thank you so much for your efforts to understand. I know it is confusing. UCs capture user behavior (no implementation information), pseudocode for hte test describe the actual code that will be written but not in real syntax. |
Here is an example of pseudocode for the test.
something like that. |
OK, so for --is-test, since it is not for general users, here we directly consider its test function to consider its behavior right? |
alternatively, since a goal is for that creation time to actually appear in the file, we could write a file and then check that the right time is in there. On the whole, I think if we check that the right thing is loaded in args, and then later we make a test that checks that everything from args makes it into the file, this accomplishes the same thing |
I am afraid I don't understand your question. We may not need |
Yes, that's what yucong and I previously thought about since for creation-time we may not use --is-test since we use freezegun to freeze time to test the datetime behavior. but for other cases, we might still use --is-test flags, so we might use it elsewhere. |
in that case it is not needed in this PR at all. |
Let's hold on this until we are sure it is needed. It is not something i want unless it is absolutely needed. |
90% of tests will pass without the
--is-test
flag set, but for consistency, I suggest we add this to all the tests. It will create less confusion in the future .The text was updated successfully, but these errors were encountered: