Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DropdownMenu): Add portal support #1289

Merged
merged 8 commits into from
Jan 2, 2024
Merged

feat(DropdownMenu): Add portal support #1289

merged 8 commits into from
Jan 2, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 2, 2024

Resolves #1286

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 2. Jan 2024 - 15:01 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review January 2, 2024 12:16
mimarz
mimarz requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we also add a separate story for enabled portal, so they can see its floating "outside" the iframe in storybook.

packages/react/src/types/Portal.ts Outdated Show resolved Hide resolved
@Barsnes @mimarz
Update packages/react/src/types/Portal.ts
0e9e9c6 
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
@Barsnes Barsnes requested a review from mimarz January 2, 2024 12:54
@Barsnes Barsnes marked this pull request as draft January 2, 2024 13:05
@Barsnes Barsnes marked this pull request as ready for review January 2, 2024 13:42
mimarz
mimarz approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Barsnes Barsnes merged commit a0ff1bf into main Jan 2, 2024
3 checks passed
@Barsnes Barsnes deleted the feat/dropdown-portal branch January 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@Thuneer Thuneer Awaiting requested review from Thuneer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Portal support to DropdownMenu
2 participants
@Barsnes @mimarz