fix: only one window at a time during startup. #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdistribute
force-pushed
the
startup-window
branch
from
4be5c37
to
22c2ac6
Compare
index.js
Outdated
| @@ -282,6 +282,9 @@ function notifyReady (done) { | |||
| var IS_TEST = process.env.NODE_ENV === 'test' | |||
| if (IS_TEST) win.setSize(1000, 800, false) | |||
| if (argv.debug) win.webContents.openDevTools() | |||
|
|
|||
| win.maximize() | |||
| win.setFullScreen(true) | |||
There was a problem hiding this comment.
I would avoid to call win.setFullScreen(true)
it sets the app...fullscreen (here on ubuntu) and I don't think is the desired behaviour
maybe win.maximize() is enough
There was a problem hiding this comment.
You're right good catch! thanks!
okdistribute
force-pushed
the
startup-window
branch
from
22c2ac6
to
4212b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #283
Contributor checklist:
Script and updated it if necessary.
npm install --package-lockDescription
Tested this on my linux laptop.
This bug was introduced with the new window state manager.