Use separate autoupdate feed url for Windows 32-bit build #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
commented
Jun 30, 2021
achou11
commented
Jun 30, 2021
| @@ -71,7 +69,7 @@ jobs: | |||
| MAPEO_VARIANT: ${{ matrix.variant }} | |||
| - name: Cleanup artifacts | |||
| run: | | |||
| npx rimraf@2 'dist/${{ matrix.variant }}/!(*.exe|*.deb|*.AppImage|*.dmg)' | |||
| npx rimraf@2 'dist/${{ matrix.variant }}/!(*.exe|*.deb|*.AppImage|*.dmg|*.yml|github)' | |||
There was a problem hiding this comment.
We want to retain generated yaml files and github/ directory for debugging purposes
achou11
commented
Jun 30, 2021
achou11
commented
Jun 30, 2021
| @@ -110,7 +110,7 @@ | |||
| "electron-is-dev": "^1.1.0", | |||
| "electron-rabbit": "^1.0.3", | |||
| "electron-timber": "^0.5.1", | |||
| "electron-updater": "^4.2.2", | |||
| "electron-updater": "^4.3.9", | |||
There was a problem hiding this comment.
Wasn't sure if we should pin this but decided against doing so since I don't think it's strictly tied to the electron-builder version
gmaclennan
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
Notes:
/desktop-ia32directory in S3 (or whatever we decide to call it)electron-builderversion to the most recent version that supports Node v12electron-updaterversion to the one that was released with the builder version we're usingelectron-publishpatch to match the new version that's being used