You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in the Daml-Finance test suite, the tests create instruments directly thusly bypassing their related Factory. In order to make the tests closer to how the library is expected to be used, update the tests to use their related Factory instead.
The text was updated successfully, but these errors were encountered:
Our current implementation to solve #753 requires the use of a factory in order to work (and be tested in the repo). I have changed it for the Callable Bond test, and the code did not get that much more complicated. It is also in a test util function, so the code is being reused for all callable bonds. @georg-da I would suggest changing this for the other dynamic instruments as well, what do you think?
Currently in the Daml-Finance test suite, the tests create instruments directly thusly bypassing their related
Factory
. In order to make the tests closer to how the library is expected to be used, update the tests to use their relatedFactory
instead.The text was updated successfully, but these errors were encountered: