Enhancements to hover #317
Conversation
|
Some functions had to be moved to a new module to prevent cyclic dependencies. |
|
Is there some special configuration for showing documentation? |
|
Not in theory, although you might need to install your libraries with
documentation. Try some Prelude functions, they should work.
Also, the corresponding GHC functionality is only available from 8.4.
El vie., 10 ene. 2020 13:25, Domen Kožar <notifications@github.com>
escribió:
… Is there some special configuration for showing documentation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#317>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACLQVWVD5YVFV4NAFWGVUDQ5BSKBANCNFSM4KFGPMBA>
.
|
|
The documentation for |
|
@cocreature could we try to get this for release 0.6? This solves a bunch of hover bugs, and complements the showing of docs in completions with showing them on hover. Unfortunately, it seems that there's some conflict with the solution of #318. For some reason, the fixes break, and I guess this comes from my code for getting the type of literals. Maybe the tests are wrong once we have hovers for literals? |
|
It turns out that some tests had to be updated. Now everything should work! |
|
Sorry this has to wait for the next release. Postponing releases to get in more stuff only results in them getting delayed further and further and this isn’t a regression compared to 0.0.5 so I don’t think there is a particular reason why this has to be in 0.0.6. As for the change, I’ll take a detailed look at this PR next week. |
|
That makes complete sense! |
| let n = unLoc v | ||
| docs <- getDocumentationTryGhc tms n | ||
| ty <- catchSrcErrors "completion" $ do | ||
| name' <- lookupName n |
There was a problem hiding this comment.
lookupName doesn’t work on ghc-lib. See the CPP for completions to disable this.
|
@serras, this looks great, but some parts of the
|
|
@moodmosaic thanks for the catch! The algorithm for transforming Haddock docs into Markdown is quite naïve, so it's quite easy to get a problem. I guess the best next step is to write a bug report and I'll try to have a look at it :) |
That's fine 👍 If you want, I can open an issue for it, or even try to fix it, just let me know where that (issue) should be opened. |
|
I'm not a maintainer, but I guess that using the issue tracker for the project is the best thing. |
* Show kinds in hover * Documentation on hover * Enable kind tests * Fix tests * Print literals * Show (some) overloaded literals * Fix for 8.4 * Fix tests * Do not consider literals for definitions * Suggestions by @cocreature * No warning for 8.4 * More fixes for 8.4 * Make it work with ghc-lib * More fixes for warnings when compiled with ghc-lib * More fixes to build in ghc-lib * Try once again to build with ghc-lib * More fixes for ghc-lib * Fix warning with ghc-lib
* Show kinds in hover * Documentation on hover * Enable kind tests * Fix tests * Print literals * Show (some) overloaded literals * Fix for 8.4 * Fix tests * Do not consider literals for definitions * Suggestions by @cocreature * No warning for 8.4 * More fixes for 8.4 * Make it work with ghc-lib * More fixes for warnings when compiled with ghc-lib * More fixes to build in ghc-lib * Try once again to build with ghc-lib * More fixes for ghc-lib * Fix warning with ghc-lib
* Show kinds in hover * Documentation on hover * Enable kind tests * Fix tests * Print literals * Show (some) overloaded literals * Fix for 8.4 * Fix tests * Do not consider literals for definitions * Suggestions by @cocreature * No warning for 8.4 * More fixes for 8.4 * Make it work with ghc-lib * More fixes for warnings when compiled with ghc-lib * More fixes to build in ghc-lib * Try once again to build with ghc-lib * More fixes for ghc-lib * Fix warning with ghc-lib
* Show kinds in hover * Documentation on hover * Enable kind tests * Fix tests * Print literals * Show (some) overloaded literals * Fix for 8.4 * Fix tests * Do not consider literals for definitions * Suggestions by @cocreature * No warning for 8.4 * More fixes for 8.4 * Make it work with ghc-lib * More fixes for warnings when compiled with ghc-lib * More fixes to build in ghc-lib * Try once again to build with ghc-lib * More fixes for ghc-lib * Fix warning with ghc-lib
Textand lists still missing)