This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Upgrade to lsp-test-0.11 #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukel97
force-pushed
the
lsp-test-0.11.0.0
branch
from
5db043d
to
728ca17
Compare
mpickering
reviewed
May 16, 2020
hie.yaml
Outdated
| @@ -1 +1,6 @@ | |||
| cradle: {stack: {component: "ghcide:lib"}} | |||
There was a problem hiding this comment.
Not sure you meant to commit this.
There was a problem hiding this comment.
Whoops, I did not. But it is useful for working on the tests. Would anyone object to a separate PR for this?
|
One comment. Otherwise looks good. |
Replace openDoc' with createDoc which sends out workspace/didChangedWatchedFiles notifications
lukel97
force-pushed
the
lsp-test-0.11.0.0
branch
from
728ca17
to
8ee5681
Compare
cocreature
approved these changes
May 17, 2020
|
Indeed. Whilst I was creating it I thought it would be more transparent to have lsp-test implement an actual filesystem watcher, and have the test suite create physical files |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
Replace openDoc' with createDoc which sends out workspace/didChangedWatchedFiles notifications
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
Replace openDoc' with createDoc which sends out workspace/didChangedWatchedFiles notifications
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
Replace openDoc' with createDoc which sends out workspace/didChangedWatchedFiles notifications
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-test-0.11 has replaced openDoc' with createDoc which sends out workspace/didChangedWatchedFiles notifications, so the wrapper in #322 shouldn't be needed anymore