Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Don't reference internal PHP classes #21

Open
lazka opened this issue Apr 17, 2023 · 0 comments
Open

config: Don't reference internal PHP classes #21

lazka opened this issue Apr 17, 2023 · 0 comments

Comments

@lazka
Copy link
Member

lazka commented Apr 17, 2023

Instead of

  payment_types:
    tuition_fee:
      service: 'Dbp\Relay\MonoConnectorCampusonlineBundle\Service\TuitionFeeService'
  payment_types:
    tuition_fee:
      provider: 'tuition_fee_provider'

where tuition_fee_provider is defined in the CO bundle config.

This way we don't expose PHP stuff to the config, which means we can change it later on, and is less confusing to the integrator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant