Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to i18next v4 format #31

Closed
lazka opened this issue May 25, 2023 · 2 comments
Closed

Port to i18next v4 format #31

lazka opened this issue May 25, 2023 · 2 comments

Comments

@lazka
Copy link
Member

lazka commented May 25, 2023

Now that we have switched to i18next-parser we can also switch the json format to the newer version.

https://www.i18next.com/misc/json-format#i18next-json-v4

Todo:

  • switch i18next-parser to v4
  • switch the i18next init to v4
  • port all apps, foreach:
    • update toolkit
    • switch i18next-parser to v4

v4 requires https://developer.mozilla.org/en-US/docs/web/javascript/reference/global_objects/intl/pluralrules -> https://caniuse.com/intl-pluralrules

Which means we would drop support for Safari<13. If we do this then we need to add a check for (typeof Intl === 'undefined' || !Intl.PluralRules) to the browser check script.

@lazka
Copy link
Member Author

lazka commented May 25, 2023

We have dropped Safari<13 now, so this could be started.

@ruxandragherman
Copy link
Contributor

Issue fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants