Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency commons-httpclient #1063

Open
arnovdk opened this issue Jan 26, 2024 · 1 comment
Open

Bump dependency commons-httpclient #1063

arnovdk opened this issue Jan 26, 2024 · 1 comment
Assignees
Projects

Comments

@arnovdk
Copy link

arnovdk commented Jan 26, 2024

Currently, the artifact uk.gov.nationalarchives:droid-container:6.7.0 has a dependency on commons-httpclient:commons-httpclient:3.1. IntelliJ IDEA flags this as having the following problems:

Closer inspection tells me that it's the class uk.gov.nationalarchives.droid.container.httpservice.ContainerSignatureHttpService that is dependent on commons-httpclient. And as far as I can tell, no other classes in the droid artifacts (droid-api, droid-container, droid-core, droid-core-interfaces, droid-parent) have any dependency on that class.

I use the artifact droid-api (and thus droid-container) as a library in software that we develop and I'm pretty sure that the class ContainerSignatureHttpService is never used, so nor is the dependency commons-httpclient. All in all the problem seems relatively small.

Still, it might be nice to refactor the mentioned class to use a newer version of HttpClient (say, 4.x or even 5.x).

@arnovdk arnovdk changed the title Bump dependency commons-httpclient to Bump dependency commons-httpclient Jan 26, 2024
@sparkhi
Copy link
Collaborator

sparkhi commented Feb 1, 2024

Thanks for pointing it out, Droid uses the dependency-check-maven plugin and the build fails if the vulnerability is severe. Looks like one of them is missing out on score.

@sparkhi sparkhi self-assigned this Apr 10, 2024
@sparkhi sparkhi added this to To Do in Droid 6.8.0 Apr 10, 2024
@sparkhi sparkhi moved this from To Do to Review in Droid 6.8.0 Apr 10, 2024
@sparkhi sparkhi moved this from Review to Done in Droid 6.8.0 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants