AntiPattern: Use of enum.ordinal() in DROID code

[nishihatapalmer]

There are lots of place in DROID which convert enums to their ordinal() value and back again. This is very fragile, as any re-ordering of these enums will break parts of DROID (at least, the parts that store the values in the SQL database and retrieve them).

Although this isn't urgent, it is something which makes DROID code unnecessarily fragile. Replacing the use of ordinal() with a fixed id for each enum value would make things much more resilient.

It's not quite as easy as just going through all the code and replacing the usage, as some of the SQL code seems to only have an enum (it doesn't know what kind of enum it is, so wouldn't be able to call special methods on it - only ordinal().