Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt-1196 SIARD 2.1 is wrongly identified as ZIP #418

Closed
sparkhi opened this issue Mar 12, 2020 · 4 comments · Fixed by #421
Closed

fmt-1196 SIARD 2.1 is wrongly identified as ZIP #418

sparkhi opened this issue Mar 12, 2020 · 4 comments · Fixed by #421
Assignees
Labels
Milestone

Comments

@sparkhi
Copy link
Collaborator

sparkhi commented Mar 12, 2020

Getting an identification error with skeleton suite, fmt-1196 SIARD 2.1 is identifying as a ZIP file - x-fmt/263. Getting this in cmd line and gui for Raspbian and win 10 jre version. 6.4 is identifying correctly. Tested on actual SIARD file from https://github.com/sfa-siard/SiardGui/blob/master/testfiles/sql2008.siard as well and got same behavior.

@sparkhi sparkhi added this to Backlog in DROID Kanban board 6.5 via automation Mar 12, 2020
@ross-spencer
Copy link

ross-spencer commented Mar 13, 2020

Hi @sparkhi just trying to parse this, is the skeleton suite the only one not identifying correctly, or sql2008.siard as well? There was a SIARD related issue in the Skeleton generation, documented a little here but should (I think) be updated and available in the most recent suite. This is marked pre-release as I haven't posted it to Zenodo yet.

@sparkhi sparkhi moved this from Backlog to In progress in DROID Kanban board 6.5 Mar 13, 2020
@sparkhi sparkhi self-assigned this Mar 13, 2020
@sparkhi
Copy link
Collaborator Author

sparkhi commented Mar 13, 2020

Hi @ross-spencer I had created the issue as seen by @paulyoung84 I'm in the process of finding more details. Thanks for the prompt comment, I'll try and get more details.

@sparkhi
Copy link
Collaborator Author

sparkhi commented Mar 13, 2020

Okay, done few more tests.

  1. Droid 6.4 vanilla - identified it as ZIP
  2. Did the signature updates on Droid 6.4 and tried - It is identified as SIARD 2.1
  3. Ran Droid 6.5 with the signatures from step 2, identified as ZIP

So I suspect the issue is in Droid 6.5 code

@ross-spencer
Copy link

Okay, thanks @sparkhi!

@jcharlet jcharlet added the bug label Mar 18, 2020
@jcharlet jcharlet added this to the 6.5 milestone Mar 18, 2020
DROID Kanban board 6.5 automation moved this from In progress to Done Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants