Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-import as a peerDependency to rules #38

Open
aljones15 opened this issue Mar 13, 2020 · 1 comment
Open

Add eslint-plugin-import as a peerDependency to rules #38

aljones15 opened this issue Mar 13, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aljones15
Copy link
Collaborator

This is an amazing plugin with a long history:

https://www.npmjs.com/package/eslint-plugin-import

probably 100% worth it, but need consensus on this one.

@aljones15 aljones15 self-assigned this Mar 13, 2020
@mandyvenables mandyvenables added the enhancement New feature or request label Jun 25, 2020
@aljones15
Copy link
Collaborator Author

Bumping this issue as we are now supporting es6 imports in bedrock, so this means rules such as:

Ensure imports point to a file/module that can be resolved. (no-unresolved)
Ensure named imports correspond to a named export in the remote file. (named)
Ensure a default export is present, given a default import. (default)
Ensure imported namespaces contain dereferenced properties as they are dereferenced. (namespace)
Restrict which files can be imported in a given folder (no-restricted-paths)
Forbid import of modules using absolute paths (no-absolute-path)
Forbid require() calls with expressions (no-dynamic-require)
Prevent importing the submodules of other modules (no-internal-modules)
Forbid webpack loader syntax in imports (no-webpack-loader-syntax)
Forbid a module from importing itself (no-self-import)
Forbid a module from importing a module with a dependency path back to itself (no-cycle)
Prevent unnecessary path segments in import and require statements (no-useless-path-segments)
Forbid importing modules from parent directories (no-relative-parent-imports)
Prevent importing packages through relative paths (no-relative-packages)

Are suddenly super useful. I would like to see no-unresolved immediately.

@aljones15 aljones15 changed the title Evaluate eslint-plugin-import Add eslint-plugin-import as a peerDependency to rules Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants