Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lacks license grant (contains license but no information of what that might cover) #13

Open
jonassmedegaard opened this issue Jan 12, 2019 · 6 comments

Comments

@jonassmedegaard
Copy link

Please include a statement from the copyright holders of what licensing terms they grant for which of the creative works that they own copyright for.

The project ships with a general license, and the package.json contains a license hint. But nowhere is documented who grants said licensing terms to what exactly. On the contrary, some files contain the statement "All rights reserved" which is conventional non-copyleft licensing - i.e. the default when nothing else is stated (and stating that explicitly is superfluous since 30 years!)

Please consider adding an explicit license grant - at minimum similar to jsonld project, but preferably at the top of each copyright-protected file next to (or instead of) that superfluous "All rights reserved" statement which it negates.

@davidlehn
Copy link
Member

I'm a bit confused about you are asking for here. There is a LICENSE file and I think all the significant files have a Copyright comment. Is that not enough? What are you recommending?

@jonassmedegaard
Copy link
Author

Essentially I ask/recommend that whenever you feel the need to state copyright you also feel the pleasure to license.

Or put differently: I am talking about the point "Put a license notice in each file" at https://www.gnu.org/licenses/gpl-howto.html - which I believe is a fine document regardless of your passion or not for that particular organisation and that particular license.

@jonassmedegaard
Copy link
Author

jonassmedegaard commented Jan 14, 2019

A "license grant" a.k.a. a "license notice" is different from a "license" a.k.a. "license file".

@davidlehn
Copy link
Member

I'm still unsure what action to take here. Are you suggesting adding license info to each file? That's kind of a pain to do. If it's something else could you be more explicit on what the suggested change is? This code came from jsonld.js originally so both projects are doing similar things with license notification.

@jonassmedegaard
Copy link
Author

jonassmedegaard commented Mar 11, 2019 via email

@jonassmedegaard
Copy link
Author

jonassmedegaard commented Mar 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants