This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Unit Testing #110
Merged
Unit Testing #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCharlatan
force-pushed
the
Testing
branch
2 times, most recently
from
7580426
to
54f5577
Compare
This commit implements a first couple of unit tests for the middleware. It also adds a script that checks the current coverage of the implemented units tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on #109
The pr implements basic unit tests for the base. The coverage of the tests can be checked by running the
coverage.shscript. From the middleware directory, run it withscripts/coverage.sh ./src/....While implementing the tests I found some weaknesses in the error handling of the websocket read and write loop and the checks when noise is not properly setup yet.