Renew app icon

[validblock]

Updating app icon according to the Human Interface Guidelines.

[thisconnect]

Thanks @validblock , there is also trayicon.png (the one shown in the macos menu) and icon.icns (afaik used for the actual app icon) that should be updated at the same time.

Would you mind share the source file?

[validblock]

trayicon.png (the one shown in the macos menu)

Do we really need the menu? The menu does one little thing: Quit the app. Just saying ;)

icon.icns

I saw, the icns file will be generated by using convert_icon.sh from the updated app_icon_source.png file.

Attached all resources used by me.
Archive.zip

[benma]

Do we really need the menu? The menu does one little thing: Quit the app. Just saying ;)

The menu is actually needed to enable desktop notifications, as strange as that sounds. It's a Qt restriction.

[thisconnect]

@validblock thanks for the resources.

ACK from my side to the new macOS desktop icon, but I guess the Android icon should stay as is.

[validblock]

ACK from my side to the new macOS desktop icon, but I guess the Android icon should stay as is.

I would create a single icon for each OS. No convert scripts from a master icon anymore.

[validblock]

I try to generate an Android app icon by using the Android Asset Studio. The result is the same icon set as already exists. No difference. Stay this way.

[validblock]

Regarding to the article Create a macOS Menu Bar Application I would suggest the following tray icon:

White Shift Crypto logo on a transparent background with spacing/padding around

Ok? Then I will update the pull request by replacing the trayicon.png.

[thisconnect]

Ok? Then I will update the pull request by replacing the trayicon.png.

I think it makes sense to update the trayicon.

I saw, the icns file will be generated by using convert_icon.sh from the updated app_icon_source.png file.

Could you also run convert_icon.sh and update https://github.com/digitalbitbox/bitbox-wallet-app/blob/master/frontends/qt/resources/MacOS/Testnet.app/Contents/Resources/icon.icns ?

also I wanted ping @jadzeidan but forgot, PTAL

[jadzeidan]

Ack. Change makes sense. LGTM :)

[thisconnect]

@validblock do you have time to commit the generated icons too so we could just merge this?

[thisconnect]

LGTM

[thisconnect]

@benma could you test Android?

[benma]

@thisconnect is the icon supposed to change on all platforms? If so, the icons on Android, Windows and Linux have to be compiled as well.

• frontends/qt/resources/win/convert.sh
• frontends/android/mkicon.sh
• frontends/qt/resources - make

I ran these and this is the output for me: benma@0bac53f

After this, on Android it looks like this (DEBUG is new, BitBoxApp is old)

On linux:

Before:

After:

Is this good?

[thisconnect]

macOS and linux LGTM.

I don't like that the logo is so big on Android.

CC @jadzeidan WDYT?

[jadzeidan]

macOS and linux LGTM.

I don't like that the logo is so big on Android.

CC @jadzeidan WDYT?

LGTM with nit on Android that the logo is too large compared to the background. Ideally would look more like this:

[jadzeidan]

I'm not sure how the Android icon is generated. Is the background autogenerated and you just need to provide the correct size logo in the middle?

[benma]

@jadzeidan see my comment above

https://github.com/digitalbitbox/bitbox-wallet-app/blob/master/frontends/android/mkicon.sh

so it looks like the original but just resized to various sizes.

[jadzeidan]

@jadzeidan see my comment above

https://github.com/digitalbitbox/bitbox-wallet-app/blob/master/frontends/android/mkicon.sh

So what's the best fix to make the logo on Android smaller. Provide a smaller logo specifically for Android?

[benma]

In the info screen it looks good however:

Seems my launcher somehow cuts off the icon a bit.

[benma]

There is also a "round icon", what a nightmare 😂

https://github.com/digitalbitbox/bitbox-wallet-app/blob/master/frontends/android/BitBoxApp/app/src/main/AndroidManifest.xml#L18

[thisconnect]

So what's the best fix to make the logo on Android smaller. Provide a smaller logo specifically for Android?

I'd assume it looks better if there is a bit more whitespace for the android?

Alternative: keep as is or change the old one to have a white BG ?

[jadzeidan]

I'd assume it looks better if there is a bit more whitespace for the android?

Yes I think so too.

Alternative: keep as is or change the old one to have a white BG ?

I don't like the old one because it has a background in a background (below).

So I think we should change it so it looks like this:

So the question what is the best way to do that?

[thisconnect]

@jadzeidan could you make a different icon for android that has 20% white space on each side? so the actual logo takes up about 60% of the image?

[jadzeidan]

@thisconnect

Does this work?

[jadzeidan]

@thisconnect here is PNG version:

[validblock]

Any blocker there?

[benma]

@validblock sorry the blocker here was me, I was absent for two weeks and need to test the above Android logo. Will do so in the coming days. Sorry that this PR is taking so long 🤯

[benma]

Sorry for the very long delay!

@jadzeidan the icon you provided looks good to me:

(BitBoxApp DEBUG is new, BitBoxApp is old).

Too bad it is not documented anywhere how the round icons were generated :/

@validblock i took the liberty of adding a commit to this PR with the change for Android.

@thisconnect anything else missing or is this good to squash and merge?

[thisconnect]

LGTM @benma squash and merge!

[benma]

Thanks very much @validblock and sorry again that this took so long!